Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: make structuredClone spec compliant #40251

Closed
wants to merge 1 commit into from
Closed

lib: make structuredClone spec compliant #40251

wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

Fixes: #40246

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 29, 2021
@targos
Copy link
Member

targos commented Sep 29, 2021

It would be nice to have a WPT for this.

@targos
Copy link
Member

targos commented Sep 29, 2021

BTW, I'm not sure we should throw an error, but instead just grab transfer from the passed object and create a new options object with it.

@VoltrexKeyva
Copy link
Member Author

BTW, I'm not sure we should throw an error, but instead just grab transfer from the passed object and create a new options object with it.

We mostly just throw an error if the passed value is not spec complaint in most cases, throwing an error here would be nice for keeping consistency unless there's a special case where we have to avoid throwing an error.

@targos
Copy link
Member

targos commented Sep 29, 2021

What's important here is not consistency, but spec compliance. The spec just asks to pass options["transfer"]. Maybe I'm wrong, but I understand that it should not be an error to do this:

const options = [];
options.transfer = [toTransfer];
structuredClone({}, options);

@targos
Copy link
Member

targos commented Sep 29, 2021

Do we have a WHATWG spec specialist that we could ping to take a look?

@aduh95
Copy link
Contributor

aduh95 commented Sep 29, 2021

Maybe @surma would be available to review this, since they are the one who proposed this API to WHATWG.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40142/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40144/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021

Landed in 6199441...3d11baf

@github-actions github-actions bot closed this Oct 3, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 3, 2021
@VoltrexKeyva @nodejs-github-bot
lib: make structuredClone spec compliant
3d11baf 
Fixes: #40246

PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@VoltrexKeyva VoltrexKeyva deleted the fix-structuredclone branch October 3, 2021 15:25
@github-actions github-actions bot mentioned this pull request Oct 4, 2021
Open
22 tasks
danielleadams pushed a commit that referenced this pull request Oct 4, 2021
@VoltrexKeyva @danielleadams
lib: make structuredClone spec compliant
3fbc172 
Fixes: #40246

PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 4, 2021
@VoltrexKeyva @danielleadams
lib: make structuredClone spec compliant
57491ca 
Fixes: #40246

PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
@github-actions github-actions bot mentioned this pull request Oct 5, 2021
Open
21 tasks
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@VoltrexKeyva @danielleadams
lib: make structuredClone spec compliant
1ccecf4 
Fixes: #40246

PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@VoltrexKeyva @danielleadams
lib: make structuredClone spec compliant
ef01293 
Fixes: #40246

PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@VoltrexKeyva @danielleadams
lib: make structuredClone spec compliant
ae309ee 
Fixes: #40246

PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@VoltrexKeyva @danielleadams
lib: make structuredClone spec compliant
00b5013 
Fixes: #40246

PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 5, 2021
@VoltrexKeyva @danielleadams
lib: make structuredClone spec compliant
ddd57c5 
Fixes: #40246

PR-URL: #40251
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Oct 6, 2021
Open
Open
Open
Open
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid globalThis.structuredClone interface
7 participants
@VoltrexKeyva @targos @aduh95 @nodejs-github-bot @jasnell @benjamingr @danielleadams